Files
essim/tests/test_persist.cpp
François 90502c0762 Dashboard + palette + analyze screen; consolidated categorization rules.
UI restructuring:

- Dashboard (`screen_dashboard.cpp`, `screen_idx = 6`) is the new home
  screen at boot. Reads Overview / Health / Analysis / Modules from
  the current System every frame; per-module rows list parts grouped
  by `connector_type` and a Power/Gnd inference summary (yellow when
  any name-Power signal is refuted). Scrollable via PgUp/PgDn/Home/End.
  Letter shortcuts: `c`=console, `s`=search, `p`=plug (alias of
  connect), `t`=set-type, `e`=explore, `n`=net, `a`=analyze, `q`=quit.
- Global Ctrl-P palette (`screen_palette.cpp`) — fuzzy-finds over
  registered commands + module / signal names. Activation runs the
  bare command or jumps to the matching screen with state seeded.
- Unified analyze screen (`screen_analyze.cpp`, `screen_idx = 7`):
  tabbed layout (`Issues / Groups / Types`), Tab or ←→ to switch
  tabs, ↑/↓ to navigate the focused list. Replaces the previous
  shell-bouncing `[v]erify` shortcut — `verify` content is now in
  the Issues tab. Types tab attaches the decision rationale to each
  signal row (fan-out / voltage / hard floor).
- Context help panel: `RenderHelpPanel(title, entries)` in
  `tui_helpers.{hpp,cpp}` rendered on the right of every screen.
- Console (former "log") rename: screen 0 is `[c]onsole` in the UI
  and "console" in its help-panel title. The underlying screen and
  the shell prompt are unchanged.
- Esc from any non-home screen returns to the dashboard. The
  dashboard itself swallows Esc; quit via `q` / the `quit` command.
  `quit` now calls `screen_ptr->Exit()` directly so it works from
  any screen including via the palette.

Signal type inference:

- `Signal::type` defaults to `Other` — auto-inference no longer
  happens at construction.
- `infer_signal_types(System*)` is called at the end of every load.
  Three rules: GndShield from name alone; Power requires name match
  + a hard fan-out floor (< 3 pins = always Other, regardless of
  name or voltage) + at least one positive structural signal
  (fan-out ≥ 4 OR voltage pattern in the name like `3V3`, `5V`).
- Thresholds exposed in `analysis.hpp` (`POWER_FANOUT_HARD_FLOOR`,
  `POWER_FANOUT_CONFIRM_MIN`, `has_voltage_pattern`) so the analyze
  screen can render the same rationale without duplicating logic.
- `set-signal-type` still wins; save/restore round-trips the type.

Analysis groups & anomalies:

- New `GroupKind::DiffBus` — ≥ 2 diff pairs sharing the same
  outer-stem with consecutive integer indices are aggregated into a
  single bus (`MDI[0..3]_P/N`). `MDI0` and `PCIE_TX_0` index forms
  both accepted. Solo pairs under a bus-able stem fall back to
  `DiffPair`.
- New `AnomalyKind::DiffBusGap` for missing lanes.

Documentation:

- `DESIGN.md`: dedicated "Categorization rules (normative)" section
  consolidating signal type, NC origin, signal groups, anomalies,
  component kind, and connector wiring rules with exact thresholds
  and decision order.
- `doc/user/analysis.md` (new): user-facing version of the same
  rules in plain language. Linked from `doc/user/index.md`.

Tests: +6 new cases (62 total). Adjusted `test_persist.cpp` to set
the signal type explicitly in the fixture (no more auto-inference).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 20:23:33 +02:00

169 lines
5.2 KiB
C++

#include <doctest/doctest.h>
#include "system/connect.hpp"
#include "system/modules.hpp"
#include "system/parts.hpp"
#include "system/persist.hpp"
#include "system/pins.hpp"
#include "system/signals.hpp"
#include "system/system.hpp"
#include <filesystem>
#include <memory>
#include <string>
namespace {
std::string tmp_path(const std::string &name) {
return (std::filesystem::temp_directory_path() / name).string();
}
// Build a tiny system with two modules, parts, signals, and one connection
// with a non-trivial pin_map. Used for the round-trip test.
std::unique_ptr<System> make_fixture() {
auto sys = std::make_unique<System>();
Module *bkp = sys->modules()->merge("BKP");
Module *pl = sys->modules()->merge("PL");
Part *p1 = new Part("U1");
p1->connector_type = "vpx-3u-bkp-p0";
bkp->add(p1);
Part *p2 = new Part("J1");
p2->connector_type = "vpx-3u-payload-p0";
pl->add(p2);
auto add_pin = [](Part *p, const std::string &name,
Module *mod, const std::string &signal_name) -> Pin* {
Pin *pin = new Pin(name);
p->add(pin);
if (!signal_name.empty()) {
Signal *s = mod->signals->merge(signal_name);
s->add(pin);
pin->connect(s);
}
return pin;
};
Pin *a1_bkp = add_pin(p1, "A1", bkp, "GND");
Pin *b1_bkp = add_pin(p1, "B1", bkp, "VCC");
/*Pin *nc_bkp =*/ add_pin(p1, "C1", bkp, ""); // NC
Pin *a1_pl = add_pin(p2, "A1", pl, "GND");
Pin *c1_pl = add_pin(p2, "C1", pl, "VCC");
Connection *c = new Connection("BKP/U1 <-> PL/J1", bkp, p1, pl, p2);
c->transform_name = "vpx-3u-p0";
c->pin_map.emplace_back(a1_bkp, a1_pl);
c->pin_map.emplace_back(b1_bkp, c1_pl);
sys->connections()->add(c);
return sys;
}
} // namespace
TEST_CASE("save+restore round-trip preserves modules, parts, types, signals, NC") {
auto sys = make_fixture();
std::string path = tmp_path("essim_roundtrip.txt");
std::string err;
REQUIRE(save_system(sys.get(), path, err));
System *restored_raw = restore_system(path, err);
REQUIRE(restored_raw != nullptr);
std::unique_ptr<System> restored(restored_raw);
std::filesystem::remove(path);
CHECK(restored->modules()->size() == 2);
Module *bkp = restored->modules()->get("BKP");
Module *pl = restored->modules()->get("PL");
REQUIRE(bkp); REQUIRE(pl);
Part *p1 = bkp->get("U1");
Part *p2 = pl->get("J1");
REQUIRE(p1); REQUIRE(p2);
CHECK(p1->connector_type == "vpx-3u-bkp-p0");
CHECK(p2->connector_type == "vpx-3u-payload-p0");
CHECK(p1->size() == 3);
CHECK(p2->size() == 2);
Pin *a1 = p1->get("A1");
Pin *c1_nc = p1->get("C1");
REQUIRE(a1); REQUIRE(c1_nc);
REQUIRE(a1->signal());
CHECK(a1->signal()->name == "GND");
CHECK(c1_nc->signal() == nullptr); // NC preserved
}
TEST_CASE("save+restore preserves signal type overrides") {
// The Signal ctor defaults to Other; promotion to Power/Gnd is the job
// of `infer_signal_types(sys)` at load time. Here we just set the types
// explicitly to assert that save/restore round-trips them.
auto sys = make_fixture();
Signal *vcc = sys->modules()->get("BKP")->signals->get("VCC");
REQUIRE(vcc);
vcc->type = SignalType::Power;
Signal *gnd = sys->modules()->get("BKP")->signals->get("GND");
REQUIRE(gnd);
gnd->type = SignalType::GndShield;
std::string path = tmp_path("essim_signal_type.txt");
std::string err;
REQUIRE(save_system(sys.get(), path, err));
std::unique_ptr<System> restored(restore_system(path, err));
REQUIRE(restored);
std::filesystem::remove(path);
Signal *r_vcc = restored->modules()->get("BKP")->signals->get("VCC");
Signal *r_gnd = restored->modules()->get("BKP")->signals->get("GND");
CHECK(r_vcc->type == SignalType::Power);
CHECK(r_gnd->type == SignalType::GndShield);
}
TEST_CASE("save+restore preserves connections and pin_map") {
auto sys = make_fixture();
std::string path = tmp_path("essim_conn.txt");
std::string err;
REQUIRE(save_system(sys.get(), path, err));
std::unique_ptr<System> restored(restore_system(path, err));
REQUIRE(restored);
std::filesystem::remove(path);
CHECK(restored->connections()->size() == 1);
Connection *c = restored->connections()->get("BKP/U1 <-> PL/J1");
REQUIRE(c);
CHECK(c->transform_name == "vpx-3u-p0");
CHECK(c->pin_map.size() == 2);
// Endpoints point into the restored system, not dangling.
Module *bkp = restored->modules()->get("BKP");
Module *pl = restored->modules()->get("PL");
CHECK(c->m1 == bkp);
CHECK(c->m2 == pl);
CHECK(c->p1 == bkp->get("U1"));
CHECK(c->p2 == pl->get("J1"));
// Verify a specific wire pair.
Pin *a1_bkp = bkp->get("U1")->get("A1");
bool found_a1 = false;
for (auto &wp : c->pin_map) {
if (wp.first == a1_bkp) {
CHECK(wp.second == pl->get("J1")->get("A1"));
found_a1 = true;
}
}
CHECK(found_a1);
}
TEST_CASE("restore returns nullptr on bogus path") {
std::string err;
System *r = restore_system("/this/path/should/not/exist", err);
CHECK(r == nullptr);
CHECK(!err.empty());
}