From 41519c97cbed4f60ca7d4596ff210d84195ac5c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois?= <francois@beafrancois.fr>
Date: Tue, 5 May 2026 09:19:22 +0200
Subject: [PATCH] Fix testium --version reporting "unknown" when installed from
 a wheel
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

get_testium_version() used pkg_resources (deprecated, slow to import)
and a narrow catch on git.InvalidGitRepositoryError; any other git
exception fell through to the outer except and returned "unknown".

- Use importlib.metadata.version("testium") to read the wheel
  version that setuptools bakes from src/VERSION at build time. Works
  out of any source checkout — pip-installed copies report
  "<x.y> (wheel release)" instead of "unknown".
- Source-checkout path: tried first when prefs.git_supported, broadly
  catches Exception so a missing repo / detached worktree / etc. no
  longer hides the wheel-metadata fallback.
- PyInstaller path: graceful "unknown (binary release)" if the bundled
  VERSION file is unreadable, instead of an unhandled exception.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 src/testium/interpreter/utils/version.py | 57 +++++++++++++-----------
 1 file changed, 30 insertions(+), 27 deletions(-)

diff --git a/src/testium/interpreter/utils/version.py b/src/testium/interpreter/utils/version.py
index eee7643..3418562 100644
--- a/src/testium/interpreter/utils/version.py
+++ b/src/testium/interpreter/utils/version.py
@@ -31,39 +31,42 @@ def get_version(path :str)-> str:
         return "Warning git not supported in your settings, version of {} unknown".format(path)
 
 def get_testium_version():
-    # case where we're executing from an Appimage
+    # AppImage
     if 'APPIMAGE' in os.environ:
-        ver = 'unknown'
-        if 'SEQUENCER_REV' in os.environ:
-            ver = os.getenv('SEQUENCER_REV')
-        return (ver + " (binary release)")
+        ver = os.getenv('SEQUENCER_REV', 'unknown')
+        return ver + " (binary release)"
 
-    # case where we're executing from pyinstaller exe
+    # PyInstaller frozen exe
     if getattr(sys, 'frozen', False):
         file_path = os.path.join(sys._MEIPASS, "VERSION")
-        with open(file_path, 'r') as file:
-            ver = file.read()
-        return (ver + " (binary release)")
+        try:
+            with open(file_path, 'r') as f:
+                ver = f.read().strip()
+            return ver + " (binary release)"
+        except OSError:
+            return "unknown (binary release)"
 
-    # Executed from sources
-    try:
-        if prefs.settings.git_supported:
+    # Source checkout: prefer git revision when available
+    if prefs.settings.git_supported:
+        try:
             git = import_module("git")
-            path = tm.get_main_dir()
-            try:
-                return repo_rev(path)
-            except git.InvalidGitRepositoryError:
-                pkg_rec = import_module("pkg_resources")
-                try:
-                    ret = pkg_rec.get_distribution("testium").version
-                    _cached_versions.update({path: ret})
-                    return str(ret) + " (wheel release)"
-                except:
-                    return "Warning : testium not versioned"
-        else:
-            return "Warning git not supported in your settings, version of testium is unknown."
-    except:
-        return ("Unknown")
+            return repo_rev(tm.get_main_dir())
+        except Exception:
+            # Not a git repo (typical pip install): fall through.
+            pass
+
+    # Pip-installed wheel: use the package metadata baked from VERSION
+    try:
+        from importlib.metadata import version as _pkg_version
+        from importlib.metadata import PackageNotFoundError
+        try:
+            return _pkg_version("testium") + " (wheel release)"
+        except PackageNotFoundError:
+            pass
+    except ImportError:
+        pass
+
+    return "unknown"
 
 def get_modifications(path : str)-> str: