electronics/essim
1
0
Fork 0
Code Issues 3 Pull Requests Packages Releases Wiki Activity

Extract attach-bsdl into core; add it to the wx GUI.

Browse Source 
Second editing op into the wx frontend. Extract the logic (parse the .bsd,
apply it to the part, record bsdl_path) into core/app/edit.hpp::attach_bsdl
(Part*, path) -> {ok, error, entity, bound, unbound, ports_total}, failing
without mutation when the file can't be parsed.

The TUI `attach-bsdl` command now renders that result (output unchanged); the
wx GUI gains an Edit ▸ Attach BSDL… menu reusing PickPart() + a .bsd file
dialog. Prune the now-dead bsdl_model include from commands.cpp.

tests/test_edit.cpp: parse failure leaves the part untouched; null part. The
success path is covered by a batch run (entity + bound/total ports). 381 core
assertions green; tui + wx build clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Foué
2026-06-03 21:18:46 +02:00
parent 7e88f82446
commit b999446151
6 changed files with 91 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/test_edit.cpp
View File

@@ -37,3 +37,20 @@ TEST_CASE("set_connector_type on a null part fails cleanly") {
CHECK_FALSE(r.ok);
CHECK_FALSE(r.error.empty());
}
TEST_CASE("attach_bsdl reports a parse failure without mutating the part") {
Part p("J1");
p.add(new Pin("1"));
app::AttachBsdlResult r = app::attach_bsdl(&p, "/nonexistent-xyz/none.bsd");
CHECK_FALSE(r.ok);
CHECK(r.error.find("cannot parse") != std::string::npos);
CHECK(p.bsdl_path.empty()); // failure leaves the part untouched
}
TEST_CASE("attach_bsdl on a null part fails cleanly") {
app::AttachBsdlResult r = app::attach_bsdl(nullptr, "x.bsd");
CHECK_FALSE(r.ok);
CHECK_FALSE(r.error.empty());
}