electronics/essim
1
0
Fork 0
Code Issues 3 Pull Requests Packages Releases Wiki Activity

Extract set-signal-type into core; add it to the wx GUI.

Browse Source 
Fourth editing op into the wx frontend. Extract the type-name parse + apply
into core/app/edit.hpp::set_signal_type(Signal*, name) -> {ok, error, type},
failing without mutation on an unrecognised name. The interactive sigtype modal
keeps its own SignalType-cycling path (different interaction, trivial mutation).

The TUI `set-signal-type` command now renders that result (output unchanged).
The wx GUI gains Edit ▸ Set signal type…: a shared PickModule() helper (PickPart
now builds on it) + inline signal choice + a power/gnd/other dropdown, then the
core op, logged as "module/signal: signal type = …" and reflected.

tests/test_edit.cpp: name parsed and applied; unknown name refused without
mutation. 387 core assertions green; tui + wx build clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Foué
2026-06-03 21:27:44 +02:00
parent fc3ef333fa
commit 19dbec9672
6 changed files with 112 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/test_edit.cpp
View File

@@ -3,6 +3,8 @@
#include "core/app/edit.hpp"
#include "core/domain/parts.hpp"
#include "core/domain/pins.hpp"
#include "core/domain/signal_type.hpp"
#include "core/domain/signals.hpp"
// app::set_connector_type is pure core: validate the kind, tag the part and
// apply the connector model. No Print/dialog/FTXUI.
@@ -54,3 +56,20 @@ TEST_CASE("attach_bsdl on a null part fails cleanly") {
CHECK_FALSE(r.ok);
CHECK_FALSE(r.error.empty());
}
TEST_CASE("set_signal_type parses the name and sets the type") {
Signal s("NET");
app::SetSignalTypeResult r = app::set_signal_type(&s, "power");
CHECK(r.ok);
CHECK(r.type == SignalType::Power);
CHECK(s.type == SignalType::Power);
}
TEST_CASE("set_signal_type rejects an unknown name without mutating") {
Signal s("NET");
s.type = SignalType::Other;
app::SetSignalTypeResult r = app::set_signal_type(&s, "bogus");
CHECK_FALSE(r.ok);
CHECK(r.error.find("power, gnd, other") != std::string::npos);
CHECK(s.type == SignalType::Other); // unchanged
}